[Dashboard] Feature: Send UTM params when logging into dashboard #5400
+106
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
=======================================
Coverage 43.86% 43.86%
=======================================
Files 1076 1076
Lines 55972 55972
Branches 3910 3910
=======================================
Hits 24551 24551
Misses 30738 30738
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
11-13-send_utm_params_when_logging_into_dashboard
branch
from
96d9014 to
01e215c
Compare
MananTank
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jnsdls
requested changes
Nov 13, 2024
MananTank
force-pushed
the
11-13-send_utm_params_when_logging_into_dashboard
branch
from
01e215c to
f6d4f1c
Compare
jnsdls
reviewed
Nov 13, 2024
gregfromstl
changed the title
jnsdls
approved these changes
Nov 22, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on collecting and managing `utm_` cookies for tracking purposes during user login and middleware processing. It enhances the handling of cookies to ensure `utm_` parameters are captured and forwarded appropriately in API requests and redirects.
### Detailed summary
- Added collection of `utm_` cookies in `auth-actions.ts`.
- Modified the `doLogin` function to include `utmCookies` in the request body.
- Implemented logic in `middleware.ts` to capture `utm_` parameters from URL and set them as cookies.
- Updated redirect and rewrite functions to include `cookiesToSet` for managing cookies in responses.
- Ensured cookies are set in the response for various redirect scenarios.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
11-13-send_utm_params_when_logging_into_dashboard
branch
from
f6d4f1c to
c0ab87d
Compare
graphite-app
bot
deleted the
11-13-send_utm_params_when_logging_into_dashboard
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR enhances the handling of UTM parameters in the login process by collecting UTM cookies and forwarding them with the login request. It also updates the middleware to capture UTM parameters from the URL and set them as cookies when the user is not authenticated.
Detailed summary
auth-actions.ts.middleware.tsto capture UTM parameters from the URL.